Track last committed block in memory #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuwqyir
changed the title
iuwqyir
requested review from
AmineAfia,
catalyst17,
nischitpra and
vernonjohnson
iuwqyir
deleted the
02-19-keep_track_of_last_committed_block_in_memory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added safeguards and tracking for committed block numbers in the Committer component.
What changed?
lastCommittedBlockfield to track the highest block number committed in memorypollFromBlocktocommitFromBlockfor clarityWhy make this change?
To prevent potential data inconsistencies and improve block tracking accuracy. This change ensures the committer maintains a reliable record of processed blocks and handles edge cases where storage and memory states might differ.